Skip to content

getStyle Accept RowRange or ColumnRange Using Phpstan#4310

Merged
oleibman merged 1 commit intoPHPOffice:masterfrom
oleibman:issue4309
Jan 8, 2025
Merged

getStyle Accept RowRange or ColumnRange Using Phpstan#4310
oleibman merged 1 commit intoPHPOffice:masterfrom
oleibman:issue4309

Conversation

@oleibman
Copy link
Collaborator

@oleibman oleibman commented Jan 8, 2025

Fix #4309. No executable source code is changed, just some doc blocks, and some new tests added.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests
  • working better with tool

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • [ x Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

Provide an explanation of why this change is needed, with links to any Issues (if appropriate).
If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.

Fix PHPOffice#4309. No executable source code is changed, just some doc blocks, and some new tests added.
@oleibman oleibman added this pull request to the merge queue Jan 8, 2025
Merged via the queue into PHPOffice:master with commit 17706a9 Jan 8, 2025
12 checks passed
@oleibman oleibman deleted the issue4309 branch January 8, 2025 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

phpstan: Worksheet::getStyle does not accept RowRange or ColumnRange

1 participant