Breaking Change - 3 Defaults

[oleibman]

Fix #4092. Change default value for Csv Reader autodetect line endings. Prior behavior can be enabled via setTestAutodetect(true).

Change default value for Html Writer "better boolean" logic. Prior behavior can be explicitly enabled via setBetterBoolean(false).

Change default for Xlsx Writer forceFullCalc option. Prior behavior can be explicitly enabled via setForceFullCalc(null).

This is:

• a bugfix
• a new feature
• refactoring
• additional unit tests
• more sensible default values

Checklist:

• Changes are covered by unit tests
  • Changes are covered by existing unit tests
  • New unit tests have been added
• Code style is respected
• Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
• CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
• Documentation is updated as necessary

[u01jmg3]

I realise this is an older PR, but I've just updated from v2 to v4 of PHPSpreadsheet.

---

Change default for Xlsx Writer forceFullCalc option. Prior behaviour can be explicitly enabled via setForceFullCalc(null).

Can you clarify what behaviour change this causes? My interpretation is that forceFullCalc has changed from null to false as its default value, but I'm not sure of the ramifications.

We use $writer->setPreCalculateFormulas(false); to allow comma-separated cell references. Will the forceFullCalc change have any effect?

Thanks for all your hard work

[oleibman]

You probably don't want forceFullCalc, so you probably shouldn't be adversely affected by this change. See PR #4271 for a description of forceFullCalc and why we planned to make this change (as we eventually did).