Skip to content

Add FormulaRange to IgnoredErrors Possibilities #4393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

oleibman
Copy link
Collaborator

@oleibman oleibman commented Mar 4, 2025

When I implemented IgnoredErrors (PR #3508), I dealt only with those that I understood well enough to come up with an example. I finally found an example for FormulaRange in the wild, so this PR adds it. Still unsupported are calculatedColumn, emptyCellReferece, listDataValidation, and unlockedFormula.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

Why this change is needed?

Provide an explanation of why this change is needed, with links to any Issues (if appropriate).
If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.

oleibman added 2 commits March 3, 2025 20:16
When I implemented IgnoredErrors (PR PHPOffice#3508), I dealt only with those that I understood well enough to come up with an example. I finally found an example for FormulaRange in the wild, so this PR adds it. Still unsupported are `calculatedColumn`, `emptyCellReferece`, `listDataValidation`, and `unlockedFormula`.
@oleibman oleibman enabled auto-merge March 7, 2025 03:43
@oleibman oleibman added this pull request to the merge queue Mar 7, 2025
Merged via the queue into PHPOffice:master with commit 3ef8ec4 Mar 7, 2025
13 of 14 checks passed
@oleibman oleibman deleted the formularange branch March 7, 2025 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant