Ods Handling of Ceiling and Floor #4466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix PHPOffice#407, which went stale over 7 years ago, and is now reopened. Ods handling of CEILING and FLOOR functions is, apparently by design, subject to interoperability problems with Excel. See [FLOOR](https://wiki.documentfoundation.org/Documentation/Calc_Functions/FLOOR) and [CEILING](https://wiki.documentfoundation.org/Documentation/Calc_Functions/CEILING). Ods implements its own `CEILING.XCL` and `FLOOR.XCL` functions for interoperability purposes. PhpSpreadsheet will implement those, and `CEILING.ODS` and `FLOOR.ODS` psuedo-functions as well; none of these four will be listed in the official Functions documentation. In all of the descriptions below, FLOOR follows CEILING exactly. Ods writes its functions to Xml as follows: - CEILING.XCL becomes COM.MICROSOFT.CEILING - CEILING.MATH becomes COM.MICROSOFT.CEILING.MATH - CEILING.PRECISE becomes COM.MICROSOFT.CEILING.PRECISE - CEILING remains unchanged PhpSpreadsheet Ods Writer will do the same, plus: - CEILING.ODS becomes CEILING PhpSpreadsheet Ods Reader will act as follows: - CEILING (not preceded by 'COM.MICROSOFT.') becomes CEILING.ODS - COM.MICROSOFT.CEILING.MATH becomes CEILING.MATH - COM.MICROSOFT.CEILING.PRECISE becomes CEILING.PRECISE - COM.MICROSOFT.CEILING becomes CEILING PhpSpreadsheet Xlsx Writer will act as follows: - CEILING.ODS becomes CEILING.MATH - CEILING.XCL becomes CEILING PhpSpreadsheet Xls Writer will recognize only the CEILING and FLOOR functions. Note that the only difference between Ods CEILING and CEILING.MATH is that CEILING will return an error if the number and significance operands have opposite signs. PhpSpreadsheet implements this as `#VALUE!`.
Very peculiar implementation in Excel. PhpSpreadsheet will match it: - FLOOR(8,0) is #DIV/0. This already matched, and is the only result I understand. - CEILING(8,0) is 0 (already matched) - FLOOR.MATH(8,0) is 0 (changed to match) - FLOOR.PRECISE(8,0) is 0 (changed to match) - CEILING.MATH(8,0) is 0 (already matched) - CEILING.PRECISE(8,0) is 0 (already matched)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #407, which went stale over 7 years ago, and is now reopened. Ods handling of CEILING and FLOOR functions is, apparently by design, subject to interoperability problems with Excel. See FLOOR and CEILING. Ods implements its own
CEILING.XCLandFLOOR.XCLfunctions for interoperability purposes. PhpSpreadsheet will implement those, andCEILING.ODSandFLOOR.ODSpsuedo-functions as well; none of these four will be listed in the official Functions documentation.In all of the descriptions below, FLOOR follows CEILING exactly.
Ods writes its functions to Xml as follows:
PhpSpreadsheet Ods Writer will do the same, plus:
PhpSpreadsheet Ods Reader will act as follows:
PhpSpreadsheet Xlsx Writer will act as follows:
PhpSpreadsheet Xls Writer will recognize only the CEILING (to which it treats CEILING.XLC as an alias) and FLOOR (to which it treats FLOOR.XLC as an alias) functions.
Note that the only difference between Ods CEILING and CEILING.MATH is that CEILING will return an error if the number and significance operands have opposite signs. PhpSpreadsheet implements this as
#NUM!.This is:
Checklist: