Skip to content

Allow Xlsx Reader/Writer to Process Font Charset #4501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025

Conversation

oleibman
Copy link
Collaborator

@oleibman oleibman commented Jun 4, 2025

Fix #2760. Maybe. I have no real way of confirming. I am not sure why it might be needed, but a comment in the issue suggests that it helps. I have asked the submitter and another participant in the discussion to let me know if it helps before moving forward.

This is:

  • a bugfix (most likely workaround of an Excel bug)
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

Fix PHPOffice#2760. Maybe. I have no real way of confirming. I am not sure why it might be needed, but a comment in the issue suggests that it helps. I have asked the submitter and another participant in the discussion to let me know if it helps before moving forward.
@oleibman oleibman marked this pull request as draft June 4, 2025 04:43
@oleibman
Copy link
Collaborator Author

oleibman commented Jun 4, 2025

Scrutinizer "major" issue is a false positive which is now suppressed.

@oleibman oleibman mentioned this pull request Jun 4, 2025
@oleibman
Copy link
Collaborator Author

@Amin1990s has confirmed that change works as desired. Removing from draft status.

@oleibman oleibman marked this pull request as ready for review June 10, 2025 14:17
@oleibman oleibman changed the title WIP Allow Xlsx Reader/Writer to Process Font Charset Allow Xlsx Reader/Writer to Process Font Charset Jun 10, 2025
@oleibman oleibman added this pull request to the merge queue Jun 18, 2025
Merged via the queue into PHPOffice:master with commit 30369ca Jun 18, 2025
14 checks passed
@oleibman oleibman deleted the issue2760 branch June 18, 2025 06:39
@oleibman oleibman mentioned this pull request Jul 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Custom Font Face
1 participant