This repository was archived by the owner on Oct 17, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Feat/listar acervo fixed #189
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
| /> | ||
| <FormControl sx={{minWidth: '150px'}}> | ||
| <InputLabel>Coleção</InputLabel> | ||
| <Select |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| /> | ||
| <FormControl sx={{minWidth: '150px'}}> | ||
| <InputLabel>Coleção</InputLabel> | ||
| <Select |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
Joao-Pedro-P-Holanda
approved these changes
Sep 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature ListarAcervo
Resolve
#36
Descrição
Cria a página de listagem do acervo, exibindo os itens públicos e privados, a depender da autenticação.
Adições
Dois novos data-cy ao CardItemAcervo (item-privado e item-publico) para facilitar os testes da página de Acervo.
Página mockada idêntica a do Acervo (a única diferença é o getItensAcervo, que retorna uma lista pronta pra não acessar o firebase). Necessário por limitações do cypress.
Alterações
A página de acervo agora deve carregar os últimos 6 itens em ordem decrescente por ordem cronológica, e não mais em ordem alfabética, por padrão.
Remoções
Verificando
Desenvolvedor
Revisor