Add Windows compatibility + Minor Refactor #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds Windows compatibility to the MCP server, which includes these tasks:
pnpm
scripts to also beable to run on Windows, which involve using the packageshx
to wrap around Unix commandspnpm-workspace.yaml
to explicitly includes the supported OS and Architecturessrc/fs/sandbox
to be Windows compatible (Windows use backslash for path separators compared to Unix's forward slash)tests/unit.test.ts
so that AI-provided file paths can be OS-agnostic, but the resolved file paths and error message must adhere to the OS standardREADME.md
This pull request also refactored the parameter
relativeOutputPath
tooutputFilePath
since the output path ultimately get resolved viaresolveFilePath
which support both relative path and absolute path.Testing:
unit.test.ts
buid-api-examples.test.ts
andsigning-api-examples.test.ts
Discussion:
unit.test.ts
since the expected result for some test cases changes depending on the OS you are in. For example, the resolved file path can be/sandbox/test.pdf
on macOS andC:\sandbox\test.pdf