Skip to content

gcc 8.2 compatibility fixes. #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

gcc 8.2 compatibility fixes. #430

wants to merge 2 commits into from

Conversation

@zaq32
Copy link
Contributor

@zaq32 zaq32 commented Mar 18, 2019 •
edited by Novakov
Loading

This change is Reviewable

@ggajoch
Copy link
Member

ggajoch commented Mar 18, 2019

platforms/mcu/EngModel/settings.cmake, line 30 at r1 (raw file):

set (EIGEN_WARN_FIX "-Wno-int-in-bool-context")
set (RAPID_CHECK_WARN_FIX "-Wno-shift-negative-value")

AFAIR bumping RadpidCheck solves this issue

zaq32
zaq32 commented Mar 20, 2019
View reviewed changes
Copy link
Contributor Author

@zaq32 zaq32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 21 files reviewed, 1 unresolved discussion, one of Novakov, zaq32 has to review 21 files (waiting on @ggajoch)

platforms/mcu/EngModel/settings.cmake, line 30 at r1 (raw file):

Previously, ggajoch (Grzegorz Gajoch) wrote…

AFAIR bumping RadpidCheck solves this issue

Possibly, but purpose here was to ensure working build with never gcc without updating any of the external references

ggajoch
ggajoch approved these changes Mar 27, 2019
View reviewed changes
Copy link
Member

@ggajoch ggajoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 21 of 21 files at r1.
Reviewable status: all files reviewed, all discussions resolved, one of Novakov, zaq32 has to review 21 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggajoch ggajoch ggajoch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zaq32 @ggajoch