Skip to content

[FIx] CI Approve fix #4316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuanlehome merged 4 commits into from
Sep 29, 2025
Merged

[FIx] CI Approve fix #4316

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
085d112
check approve
zeroRains Sep 29, 2025
e0ba668
fix the bug
zeroRains Sep 29, 2025
1f108b2
update
zeroRains Sep 29, 2025
71d158c
Merge branch 'develop' into approve
zeroRains Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/check_approval.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ WORKER_OR_CONFIG_LIST=(
)

HAS_WORKER_OR_CONFIG_MODIFY=`git diff upstream/$BRANCH --name-only | grep -E $(printf -- "-e %s " "${WORKER_OR_CONFIG_LIST[@]}") || true`
if [ ${HAS_WORKER_OR_CONFIG_MODIFY} ] && [ "${PR_ID}" != "" ]; then
if [ "${HAS_WORKER_OR_CONFIG_MODIFY}" != "" ] && [ "${PR_ID}" != "" ]; then
echo_line1="You must have one FastDeploy RD (gongshaotian(gongshaotian), yuanlehome(liuyuanle)) approval for modifing [$(IFS=', '; echo "${WORKER_OR_CONFIG_LIST[*]}")]."
check_approval "$echo_line1" 1 gongshaotian yuanlehome
fi
Expand All @@ -70,7 +70,7 @@ SPECULATIVE_DECODING_LIST=(
)

HAS_SPECULATIVE_DECODING_MODIFY=`git diff upstream/$BRANCH --name-only | grep -E $(printf -- "-e %s " "${SPECULATIVE_DECODING_LIST[@]}") || true`
if [ ${HAS_SPECULATIVE_DECODING_MODIFY} ] && [ "${PR_ID}" != "" ]; then
if [ "${HAS_SPECULATIVE_DECODING_MODIFY}" != "" ] && [ "${PR_ID}" != "" ]; then
echo_line1="You must have one FastDeploy RD (freeliuzc(liuzichang01), Deleter-D(wangyanpeng04)) approval for modifing [$(IFS=', '; echo "${SPECULATIVE_DECODING_LIST[*]}")]."
check_approval "$echo_line1" 1 freeliuzc Deleter-D
fi
Expand Down
Loading