Skip to content

Clean up unused code in operator class #10035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tonyyang-svail merged 7 commits into from
Apr 24, 2018
Merged

Clean up unused code in operator class #10035

tonyyang-svail merged 7 commits into from
Apr 24, 2018

Conversation

@tonyyang-svail
Copy link

@tonyyang-svail tonyyang-svail commented Apr 18, 2018 •
edited
Loading

  1. delete unused OperatorBase::IsNetOp() and OperatorBase::Rename()
  2. delete unsed OperatorBase::ShareLoD

@tonyyang-svail tonyyang-svail requested a review from reyoung April 18, 2018 20:43
@tonyyang-svail tonyyang-svail changed the title [WIP] Clean up unused code in operator class Clean up unused code in operator class Apr 24, 2018
helinwang
helinwang approved these changes Apr 24, 2018
View reviewed changes
Copy link
Contributor

@helinwang helinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tonyyang-svail tonyyang-svail merged commit 81dfc0c into PaddlePaddle:develop Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@helinwang helinwang helinwang approved these changes

@reyoung reyoung Awaiting requested review from reyoung

Assignees

No one assigned

Labels

Code Cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tonyyang-svail @helinwang