follow some comments with issue 973 #1006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
wangkuiyi
reviewed
Dec 27, 2016
Collaborator
wangkuiyi
left a comment
wangkuiyi
left a comment
There was a problem hiding this comment.
赞！
一个小建议：cross_map_normal_op.cpp 这样的文件名我理解可以不用修改成 CrossMapNormalOp.cpp ，因为我理解前者是符合Google naming convention 的，而我们Paddle项目虽有“习惯”，但是貌似并没有“规范”，也没有可以在PR review comments里可以贴的规范的URL。是不是不如直接用Google style得了。
wangxicoding
pushed a commit
to wangxicoding/Paddle
that referenced
this pull request
Dec 9, 2021
* fix path issue on deploy mode * fix path issue on deploy mode
lizexu123
pushed a commit
to lizexu123/Paddle
that referenced
this pull request
Feb 23, 2024
zhangyuqin1998
pushed a commit
to zhangyuqin1998/Paddle
that referenced
this pull request
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #973
And follow some comments whit pr #854
@tianbingsz This commit has modified 'function/CMakeLists.txt', the file name of Function are modified into uppercase.