Enable delay op feature #10119
Merged
Enable delay op feature #10119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengduoZH
force-pushed
the
rollback_delay_op
branch
from
c5155b4 to
f5b4ac6
Compare
panyx0718
approved these changes
Apr 23, 2018
Contributor
panyx0718
left a comment
panyx0718
left a comment
There was a problem hiding this comment.
Thanks for fixing it. If necessary, you may delete delay_op feature to simplify the codes. After 5.1, we can look into the op scheduling problem systematically.
Contributor
Author
|
@panyx0718 ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the delay_ops feature is invalid.
if (ready_ops.empty() && allow_op_delay_)does not ensure the delayed op should be executed right now when we use thread pool to execute all the ready ops.