split optimization ops on pserver to independenty blocks #10123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typhoonzero
reviewed
Apr 22, 2018
Contributor
typhoonzero
left a comment
typhoonzero
left a comment
There was a problem hiding this comment.
Thanks for fix this, the issue is introduced by #10027
| opt_state_block = None | ||
| if global_ops: | ||
| opt_state_block = pserver_program.create_block(per_opt_block.idx) | ||
| for glb_op in global_ops: |
Contributor
There was a problem hiding this comment.
can move inside if statement.
| # append op to the current block | ||
| per_opt_block = append_block | ||
| per_opt_block = None | ||
| pre_block_idx = GLOBAL_BLOCK_IDX |
Contributor
There was a problem hiding this comment.
No globals is needed here, just record the latest block id.
typhoonzero
reviewed
Apr 22, 2018
Contributor
typhoonzero
left a comment
typhoonzero
left a comment
There was a problem hiding this comment.
LGTM except one comment
| LOOKUP_TABLE_GRAD_TYPE = "lookup_table_grad" | ||
| RPC_CLIENT_VAR_NAME = "RPC_CLIENT_VAR" | ||
|
|
||
| GLOBAL_BLOCK_IDX = 0 |
typhoonzero
previously approved these changes
Apr 22, 2018
Contributor
typhoonzero
left a comment
typhoonzero
left a comment
There was a problem hiding this comment.
Approve, can remove that line later.
typhoonzero
approved these changes
Apr 22, 2018
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tasks: #9941