Skip to content

add lookup_sparse_table_op #10164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Yancey0623 merged 6 commits into from
May 2, 2018
Merged

add lookup_sparse_table_op #10164

Yancey0623 merged 6 commits into from
May 2, 2018

Conversation

@Yancey0623
Copy link
Contributor

@Yancey0623 Yancey0623 commented Apr 24, 2018 •
edited
Loading

Fixed #10046
Task #9211

@jacquesqiao
Copy link
Member

jacquesqiao commented Apr 24, 2018

Why should we add another lookup_table? In my mind, we can reuse the old lookup_table_op.

jacquesqiao
jacquesqiao reviewed Apr 24, 2018
View reviewed changes
paddle/fluid/operators/lookup_sparse_table_op.cc
public:
LookupSparseTableOpMaker(OpProto *proto, OpAttrChecker *op_checker)
: framework::OpProtoAndCheckerMaker(proto, op_checker) {
AddInput("W",
Copy link
Member

@jacquesqiao jacquesqiao Apr 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add an attribute "auto_add_id" or something like this.

Copy link
Contributor Author

@Yancey0623 Yancey0623 Apr 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@typhoonzero
Copy link
Contributor

typhoonzero commented Apr 24, 2018

Agree with @jacquesqiao , current lookup_table_op can also use Get to get value from the table if weight is SelectedRows

@Yancey0623
Copy link
Contributor Author

Yancey0623 commented Apr 25, 2018

Hi @typhoonzero @jacquesqiao
Maybe we can't reuse lookup_table_op, because of the table variable is a const Input var in it. We need another new op to implement the Compute(No Kernel Op) so that we can edit the input var.

typhoonzero
typhoonzero approved these changes Apr 27, 2018
View reviewed changes
Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Yancey0623 Yancey0623 merged commit ff99d94 into PaddlePaddle:develop May 2, 2018
@Yancey0623 Yancey0623 deleted the lookup_sparse_table_op branch May 2, 2018 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacquesqiao jacquesqiao jacquesqiao left review comments

@typhoonzero typhoonzero typhoonzero approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Yancey0623 @jacquesqiao @typhoonzero