-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Add init interface for customize devices. #10167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1bdea0a
Add init interface for customize devices.
wanghaoshuang 48b7b54
Refine code.
wanghaoshuang f31bb14
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
wanghaoshuang a0b2582
Reuse 'initP2P(bool, std::vector)' in 'initP2P(bool)'
wanghaoshuang e470856
Fix cpplint format.
wanghaoshuang a4b452a
Remove initP2P(bool) and init function in framework.
wanghaoshuang 3d96b38
Fix InitGflags.
wanghaoshuang ad3f6f4
Fix devices 'not undefined' error.
wanghaoshuang 848fb00
Fix comments.
wanghaoshuang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why there are two
Initinterfaces, one inpaddle/fluid/inference/io.h, another inpaddle/fluid/framework/init.h?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
paddle/fluid/framework/init.h中的init确实多余,也没有被其它地方用到,已经将其删除。There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qingqing01 @wanghaoshuang
Paddle/paddle/fluid/inference/io.cc
Lines 27 to 29 in c6a7042
这里有注释。因为当前
libpaddle_fluid.so不再使用whole-archive链接,而framework/init.h中的函数,没有被Fluid其他的C++代码调用到,在链接生成libpaddle_fluid.so的时候,framework/init.h里面的符号就没有链接进来。用户inference代码里面需要显式调用paddle::framework::InitDevices,在使用libpaddle_fluid.so的时候,会出现undefined symbols paddle::framework::InitDevices的错误。