Skip to content

Conversation

@dyning
Copy link
Contributor

@dyning dyning commented Apr 24, 2018

  • Expose ROI Pooling into Python API.
  • Add unit testing.

@CLAassistant
Copy link

CLAassistant commented Apr 24, 2018

CLA assistant check
All committers have signed the CLA.

@chengduoZH
Copy link
Contributor

Please sign the CLA and make CI passed first.

"""
helper = LayerHelper('roi_pool', **locals())
dtype = helper.input_dtype()
pool_out = helper.create_tmp_variable(dtype)
Copy link
Contributor

@qingqing01 qingqing01 Apr 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to create variable for Argmax.

print(str(program))

def test_roi_pool(self):
print("test_roi_pool")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

return smooth_label


def roi_pool(input, rois, pooled_height=1, pooled_width=1, spatial_scale=1.0):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"pooled_width": pooled_width,
"spatial_scale": spatial_scale
})
return pool_out, argmaxes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一般ROI pool 之后的op需要argmaxes么?如果不需要,就不用return了吧。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要的

@dyning dyning closed this Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants