Change customize_loss_grad to use_default_grad_scale.
#10223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panyx0718
previously approved these changes
Apr 26, 2018
Contributor
panyx0718
left a comment
panyx0718
left a comment
There was a problem hiding this comment.
Also update the transformer model?
| it will share variables from the specified ParallelExecutor. | ||
| use_default_grad_scale(bool, default True): If set True, a default | ||
| scale value equal to `1./device_count` would be multiplied to | ||
| the gradients. Otherwise, a customized scale value should be |
Contributor
There was a problem hiding this comment.
to gradients of each device? and then aggregated?
Contributor
Author
There was a problem hiding this comment.
Thanks, followed the comment.
| use_default_grad_scale(bool, default True): If set True, a default | ||
| scale value equal to `1./device_count` would be multiplied to | ||
| the gradients. Otherwise, a customized scale value should be | ||
| feeded to the network. |
pkuyym
commented
Apr 26, 2018
Contributor
Author
pkuyym
left a comment
pkuyym
left a comment
There was a problem hiding this comment.
Thanks for your comments and will update transformer after this PR merged.
| use_default_grad_scale(bool, default True): If set True, a default | ||
| scale value equal to `1./device_count` would be multiplied to | ||
| the gradients. Otherwise, a customized scale value should be | ||
| feeded to the network. |
| it will share variables from the specified ParallelExecutor. | ||
| use_default_grad_scale(bool, default True): If set True, a default | ||
| scale value equal to `1./device_count` would be multiplied to | ||
| the gradients. Otherwise, a customized scale value should be |
Contributor
Author
There was a problem hiding this comment.
Thanks, followed the comment.
panyx0718
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10219