Add comments and polish code #10265
Merged
Add comments and polish code #10265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typhoonzero
reviewed
Apr 27, 2018
| namespace framework { | ||
| namespace details { | ||
|
|
||
| // A SSA graph used by parallel executor. |
Contributor
There was a problem hiding this comment.
Maybe add a link to the Wikipedia page to explain what SSA is.
Collaborator
Author
There was a problem hiding this comment.
It will be added in next PR.
typhoonzero
approved these changes
Apr 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a code clean up PR to add more comments to SSAGraphBuilder and refactor code for readability.