Skip to content

Conversation

@JiayiFeng
Copy link
Collaborator

@JiayiFeng JiayiFeng commented May 2, 2018

fixes #10337

abhinavarora
abhinavarora previously approved these changes May 2, 2018

#include "cuda_runtime.h"
#include "hl_cuda.h"
#include "./cuda_runtime.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May change to #include <cuda_runtime.h> ?

#include "cuda_runtime.h"
#include "hl_cuda.h"
#include "./cuda_runtime.h"
#include "./hl_cuda.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#include "paddle/cuda/include/hl_cuda.h" is better? Please double check.

Copy link
Contributor

@pkuyym pkuyym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JiayiFeng JiayiFeng merged commit c7e23bb into PaddlePaddle:develop May 2, 2018
@JiayiFeng JiayiFeng deleted the fix_cpplint_format_check branch May 2, 2018 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cpplint error in hl_base.h

3 participants