Skip to content

Fix CPPLint issues in /math/detail/gru_kernel.h #10390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abhinavarora merged 3 commits into from
May 4, 2018
Merged

Fix CPPLint issues in /math/detail/gru_kernel.h #10390

abhinavarora merged 3 commits into from
May 4, 2018

Conversation

@abhinavarora
Copy link
Contributor

@abhinavarora abhinavarora commented May 3, 2018

No description provided.

@abhinavarora abhinavarora self-assigned this May 3, 2018
sidgoyal78
sidgoyal78 approved these changes May 4, 2018
View reviewed changes
Copy link
Contributor

@sidgoyal78 sidgoyal78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhinavarora abhinavarora merged commit c9f55df into PaddlePaddle:develop May 4, 2018
@abhinavarora abhinavarora deleted the cpplint_gru_kernel branch May 4, 2018 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sidgoyal78 sidgoyal78 sidgoyal78 approved these changes

@guoshengCS guoshengCS Awaiting requested review from guoshengCS

@wangkuiyi wangkuiyi Awaiting requested review from wangkuiyi

@putcn putcn Awaiting requested review from putcn

Assignees

@abhinavarora abhinavarora

Labels

Code Cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abhinavarora @sidgoyal78