Refine serde code #10531
Merged
Refine serde code #10531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… refine_grpc_serde_code
Yancey0623
reviewed
May 10, 2018
| if (!out_name.empty()) { | ||
| e.WriteString(VarMsg::kOutVarnameFieldNumber, out_name); | ||
| if (platform::is_gpu_place(ctx.GetPlace())) { | ||
| // GPU data is copied to CPU buffer when sending, |
Contributor
There was a problem hiding this comment.
It's better to surround this block by ifdef PADDLE_WITH_CUDA .
Contributor
Author
There was a problem hiding this comment.
It's not cuda codes actually in this block, only to free cpu memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still WIP, @gongweibao this fix the variable_response.cc proto message varints length bug, reference: https://developers.google.com/protocol-buffers/docs/encoding#packed
Part work of #9766