Polished the documentation to make it easy to understand #1079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangkuiyi
requested changes
Jan 5, 2017
|
|
||
| ``` | ||
| $ aws kms --region=us-west-2 create-key --description="kube-aws assets" | ||
| $ aws kms --region=us-west-1 create-key --description="kube-aws assets" |
Member
Author
There was a problem hiding this comment.
coreos默认是west-1，之前debian默认是west-2。
| You will use the `KeyMetadata.Arn` string to identify your KMS key in the init step. | ||
|
|
||
| And then you need to add several inline policies in your user permission. | ||
| And then you need to add several inline policies in your user permission, which located under `iam resources/users/your own account`, click the `add inline policy` at the right-botton corner. |
Collaborator
There was a problem hiding this comment.
这句话语法有问题。user permission 不能 locate 在屏幕某个地方。有些buttons/combo lists 可能locate在屏幕的某个地方。
| ] | ||
| } | ||
| ``` | ||
| NOTICE: you need to substitute `YOUR_CLUSTER_NAME` above for your own cluster name. |
Collaborator
There was a problem hiding this comment.
substitute ==> replace ... by ...
| ####Upload Training Data File | ||
|
|
||
| Here we will use PaddlePaddle's official recommendation demo as the content for this training, we put the training data file into a directory named by job name, which located in EFS sharing volume, the tree structure for the directory looks like: | ||
| Here we will use PaddlePaddle's official recommendation demo as the content for this training, we put the training data file into a directory named by job name, which located under EFS sharing volume, the tree structure for the directory looks like: |
| ``` | ||
|
|
||
| The `paddle-cluster-job` directory is the job name for this training, this training includes 3 PaddlePaddle node, we store the pre-divided data under `paddle-cluster-job/data` directory, directory 0, 1, 2 each represent 3 nodes' trainer_id. the training data in in recommendation directory, the training results and logs will be in the output directory. | ||
| The `paddle-cluster-job` directory is the job name for this training, this training includes 3 PaddlePaddle node, we store the pre-divided data under `paddle-cluster-job/data` directory, directory 0, 1, 2 each represent 3 nodes' trainer_id. the training configuration file is in recommendation directory, the training results and logs will be in the output directory after the training. |
Collaborator
There was a problem hiding this comment.
recommendation directory ==> directory recommendation
| ``` | ||
|
|
||
| The `paddle-cluster-job` directory is the job name for this training, this training includes 3 PaddlePaddle node, we store the pre-divided data under `paddle-cluster-job/data` directory, directory 0, 1, 2 each represent 3 nodes' trainer_id. the training data in in recommendation directory, the training results and logs will be in the output directory. | ||
| The `paddle-cluster-job` directory is the job name for this training, this training includes 3 PaddlePaddle node, we store the pre-divided data under `paddle-cluster-job/data` directory, directory 0, 1, 2 each represent 3 nodes' trainer_id. the training configuration file is in recommendation directory, the training results and logs will be in the output directory after the training. |
Collaborator
There was a problem hiding this comment.
我觉得不需要 after the training
| In yaml file, we describe the Docker image we use for this training, the node number we need to startup, the volume mounting information and all the necessary parameters we need for `paddle pserver` and `paddle train` processes. | ||
|
|
||
| The yaml file content is as follows: | ||
| The yaml file content is as follows, you need to fill in your own docker image uri: |
Collaborator
There was a problem hiding this comment.
docker ==> Docker 专有名词首字母大写
url ==> URL 缩写要大写
Collaborator
|
不好意思，这个PR好像是我没有及时跟进，导致一直还在这里？ 看上去和develop branch有conflict。有多大了？ |
Contributor
|
现在develop branch上的教程用的是k8s persistent volume直接指向EFS，而不是先mount到本地在用k8s host volume了。感觉这个PR已经不需要merge in了。谢谢@tizhou86提交的改进，以及@wangkuiyi的review。 |
zhhsplendid
pushed a commit
to zhhsplendid/Paddle
that referenced
this pull request
Sep 25, 2019
lizexu123
pushed a commit
to lizexu123/Paddle
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cxwangyi Tweaked some places, Guoyan is going through this tutorial step by step, we will make some tweaks later on after he complete the tutorial.