enhance memory optimization transpiler to support user defined skip_opt_set #11372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QiJune
requested review from
JiayiFeng,
dzhwinter,
jacquesqiao,
panyx0718 and
reyoung
qingqing01
reviewed
Jun 12, 2018
|
|
||
|
|
||
| def memory_optimize(input_program, print_log=False, level=0): | ||
| def memory_optimize(input_program, skip_opt_set=None, print_log=False, level=0): |
Contributor
There was a problem hiding this comment.
- Need to add comments for the new arguments.
- Need unit test.
Member
Author
There was a problem hiding this comment.
@zchengquan 你是从源码编译安装吗？
不是很确定直接修改本地安装环境中的对应文件，能否使得这个skip生效。
如果是从源码编译安装的话，在修改对应python文件后，请重新执行make install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix #11320