Fix optimizer accumulator #12103
Merged
Fix optimizer accumulator #12103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fix-optimizer-accumulator
jacquesqiao
force-pushed
the
fix-optimizer-accumulator
branch
from
a2bbd09 to
d99775a
Compare
Contributor
|
fix #12068 |
34 tasks
chengduoZH
reviewed
Jul 12, 2018
| # FIXME: Need to fix this once we figure out how to handle dependencies | ||
| self._finish_update(loss.block) | ||
| self._finish_update(loss.block, | ||
| [p[0] for p in parameters_and_grads]) |
Contributor
There was a problem hiding this comment.
_finish_update involves defining operators, so it should be in with param_and_grad[0].block.program.optimized_guard(param_and_grad[0]):.
… fix-optimizer-accumulator
… fix-optimizer-accumulator
… fix-optimizer-accumulator
chengduoZH
approved these changes
Jul 12, 2018
kuke
pushed a commit
to kuke/Paddle
that referenced
this pull request
Aug 25, 2018
…accumulator Fix optimizer accumulator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
project: #12008