add decorator skip_check_grad_ci #21836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luotao1
reviewed
Dec 19, 2019
Contributor
There was a problem hiding this comment.
there are some special(typo) cases that do not need to do check_grad.
Contributor
There was a problem hiding this comment.
This decorator is used to skip the check_grad of the above cases.
Contributor
There was a problem hiding this comment.
Other cases in NO_NEED_CHECK_GRAD_CASES will use the skip_check_grad_ci wrapper later?
Contributor
There was a problem hiding this comment.
How about the followings? i.e remove line68-71
@skip_check_grad_ci(note)
class TestLookupTableOpWithPadding(TestLookupTableOp):
def setUp(self):
xxx
def test_check_output(self):
xxx
zhangting2020
force-pushed
the
skip_check_grad_ci
branch
4 times, most recently
from
dc73883 to
18e6245
Compare
luotao1
previously approved these changes
Dec 19, 2019
Contributor
luotao1
left a comment
luotao1
left a comment
There was a problem hiding this comment.
LGTM! Nice job! Please Monitor the skip_check_grad_ci in next PR!
zhangting2020
force-pushed
the
skip_check_grad_ci
branch
from
18e6245 to
2c07b14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add decorator to skip check_grd CI:
Check_grad is required for Op test cases. However, there are specical cases that do not need to check_grad. The decorator is used to avoid failures of check_grad checking.
Note: The execution of unit test will not be skipped. It just avoids check_grad checking in tearDownClass method by setting a
no_need_check_gradflag.