Remove opencv-python in setup #2193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gangliao
approved these changes
May 18, 2017
pkuyym
reviewed
May 18, 2017
| from cv2 import resize | ||
| except: | ||
| print( | ||
| "import cv2 error, please install opencv-python: pip install opencv-python" |
Contributor
There was a problem hiding this comment.
我这边测试使用jumbo或者brew安装opencv，都可以使import cv2成功，所以提示信息仅限于pip install opencv-python是否合适？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some colleague mentioned that the opencv-python could not be installed in his platform, so remove it. The users could install it when needed.