[Api2.0] add pixel shuffle class #26071
Conversation
|
Thanks for your contribution! |
… add_pixel_shuffle_cls
… add_pixel_shuffle_cls
… add_pixel_shuffle_cls
|
|
||
|
|
||
| def pixel_shuffle(x, upscale_factor, data_format="NCHW", name=None): | ||
| """ |
There was a problem hiding this comment.
no need for duplicated docstrings for functional version, just refer to class doc
There was a problem hiding this comment.
Yep, It is the same thing.
There was a problem hiding this comment.
literally, just remove the duplicated description (bug keep the args and stuff) and add a reference to the Layer version.
… add_pixel_shuffle_cls
|
@willthefrog Codes have been refined after first time reviewing, feel free to re-review while passing tests |
willthefrog
left a comment
willthefrog
left a comment
There was a problem hiding this comment.
please reply to each comment before making new review request, otherwise it is hard for the reviewer to keep track of the changes
shippingwang
force-pushed
the
add_pixel_shuffle_cls
branch
from
5fcd94d to
59450d0
Compare
Done |
|
|
||
|
|
||
| def pixel_shuffle(x, upscale_factor, data_format="NCHW", name=None): | ||
| """ |
There was a problem hiding this comment.
literally, just remove the duplicated description (bug keep the args and stuff) and add a reference to the Layer version.
2 participants
PR types
New features
PR changes
APIs
Describe
This PR