Skip to content

Remove paddle/platform/must_check.{h,_test.cc} #2633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wangkuiyi wants to merge 1 commit into from
Closed

Remove paddle/platform/must_check.{h,_test.cc} #2633

wangkuiyi wants to merge 1 commit into from

Conversation

@wangkuiyi
Copy link
Collaborator

@wangkuiyi wangkuiyi commented Jun 28, 2017

Fixes #2632

@wangkuiyi wangkuiyi requested review from jacquesqiao and reyoung June 28, 2017 01:03
@reyoung
Copy link
Collaborator

reyoung commented Jun 28, 2017

I give another PR #2652 to do this.

I mistakenly thought we wanted to use the paddle::Error as our type of error, so I give two PR to move them into paddle::framework.

Now, we just keep it simple and use a macro PADDLE_ENFORCE, which implement in PR #2646.

@reyoung reyoung closed this Jun 28, 2017
heavengate pushed a commit to heavengate/Paddle that referenced this pull request Aug 16, 2021
@nemonameless
move ssld model (PaddlePaddle#2633)
7d2a54a 
* move ssld model, test=document_fix

* fix typo, test=document_fix
chen2016013 pushed a commit to chen2016013/Paddle that referenced this pull request Oct 17, 2025
@cheng221
fix ernie4_5 moe_layer to allgather (PaddlePaddle#2633)
804acdd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reyoung reyoung Awaiting requested review from reyoung

@jacquesqiao jacquesqiao Awaiting requested review from jacquesqiao

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wangkuiyi @reyoung