Skip to content

Conversation

@wangxicoding
Copy link
Contributor

@wangxicoding wangxicoding commented Aug 17, 2020

PR types

Others

PR changes

APIs

Describe

  1. Add paddle.sign. Deprecated paddle.fluid.layers.sign.
  2. Add paddle.tanh, alias paddle.nn.functional.tanh. Add class paddle.nn.Tanh.

Doc PR and preview PaddlePaddle/docs#2402
English doc preview:
image
image
image

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 17, 2020

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@wangxicoding wangxicoding requested a review from ForFishes August 17, 2020 08:46
@wangxicoding wangxicoding changed the title refine 2.0 sign api sign 2.0api: add name args, refine doc Aug 18, 2020
@wangxicoding wangxicoding changed the title sign 2.0api: add name args, refine doc refine sign and tanh api Aug 18, 2020
@wangxicoding wangxicoding force-pushed the refine_sign branch 2 times, most recently from 480bf2b to 476b143 Compare August 20, 2020 12:40
ForFishes
ForFishes previously approved these changes Aug 21, 2020
Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wangxicoding wangxicoding changed the title refine sign and tanh api 【API】refine sign and tanh api Aug 21, 2020
@wangxicoding wangxicoding changed the title 【API】refine sign and tanh api 【API】Add sign and tanh api Aug 21, 2020
Copy link
Contributor

@swtkiwi swtkiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
will have followup pr

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangxicoding wangxicoding merged commit ed102ea into PaddlePaddle:develop Aug 22, 2020
@wangxicoding wangxicoding deleted the refine_sign branch December 2, 2020 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants