Skip to content

fix dim problem #2636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacquesqiao merged 4 commits into from
Jun 28, 2017
Merged

fix dim problem #2636

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
98bb8ee
fix dim problem
jacquesqiao Jun 28, 2017
8b69c13
check shape of vector input, should not be a scalar
jacquesqiao Jun 28, 2017
a402cf9
correct the demo code for dense_vector label input
jacquesqiao Jun 28, 2017
e93c3e4
fix format
jacquesqiao Jun 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion paddle/py_paddle/dataprovider_converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,10 @@ def pre_scan(self, dat):
if len(self.__shape__) > 3:
raise ValueError(
"The dimension of input cannot be greater than 3.")
self.__dim__ = reduce(lambda x, y: x * y, self.__shape__)
if len(self.__shape__) == 0:
self.__dim__ = 1
Copy link
Member Author

@jacquesqiao jacquesqiao Jun 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discuss with @qingqing01 , we think if user configure to use a dence_vector, then the data type should be a vector and shape should not be zero

Copy link
Contributor

@qingqing01 qingqing01 Jun 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DenseScanner must accept the data type dense_vector. So the dat in line 108 must be a list ([]) or numpy.array. See the input type doc.

The format of input data in issue is not correct.

else:
self.__dim__ = reduce(lambda x, y: x * y, self.__shape__)
if len(self.__shape__) == 1 and self.__dim__ != self.input_type.dim:
raise ValueError(
"The data size must be equal to it in data layer.")
Expand Down