Skip to content

add div, floor_div, remainder #26562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ForFishes merged 7 commits into from
Aug 24, 2020
Merged

add div, floor_div, remainder #26562

ForFishes merged 7 commits into from
Aug 24, 2020

Conversation

@ForFishes
Copy link
Member

@ForFishes ForFishes commented Aug 22, 2020

PR types

Function optimization

PR changes

APIs

Describe

fix the divide remainder mod floor_divide, support the type promote

@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 22, 2020

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

jzhang533
jzhang533 approved these changes Aug 23, 2020
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

XiaoguangHu01
XiaoguangHu01 approved these changes Aug 23, 2020
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiqiu zhiqiu self-requested a review August 24, 2020 02:39
zhiqiu
zhiqiu approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for core.ops

@ForFishes ForFishes merged commit 0e81626 into PaddlePaddle:develop Aug 24, 2020
@ForFishes ForFishes deleted the divide_type_promote branch August 24, 2020 03:24
@ForFishes ForFishes mentioned this pull request Aug 27, 2020
Merged
This was referenced Sep 3, 2020
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jzhang533 jzhang533 jzhang533 approved these changes

@zhiqiu zhiqiu zhiqiu approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ForFishes @jzhang533 @zhiqiu @XiaoguangHu01