Skip to content

Conversation

@wangkuiyi
Copy link
Collaborator

@wangkuiyi wangkuiyi commented Jun 28, 2017

So we can write the following in paddle/framework/operator.h or somewhere in the paddle namespace:

namespace paddle {
namespace framework {
namespace detail {
namespace whatever {
...
string::Piece p = string::Printf("%2.2f", 12,345);
...

C++ compiler would be able to find out a parent namespace, which will be ::paddle, that has string::Piece.

For a verification please see https://gist.github.com/wangkuiyi/0bb245a71d3dcfc77e1e4d6961023033.

@wangkuiyi wangkuiyi requested review from helinwang and juliecbd June 28, 2017 21:53
Copy link
Contributor

@helinwang helinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wangkuiyi wangkuiyi merged commit 95cda82 into PaddlePaddle:develop Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants