Default scope function #2808
Merged
Default scope function #2808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyoung
requested review from
JiayiFeng,
QiJune,
Superjomn,
dzhwinter,
jacquesqiao,
qingqing01 and
wangkuiyi
`Paddle` manages Scope as programming language's scope. It just a thread-local stack of Scope. Top of that stack is current scope, the bottom of that stack is all scopes' parent. Invoking `create_var/get_var` can `create/get` variable in current scope. Invoking `enter_local_scope/leave_local_scope` can create or destroy local scope. A `scoped_function` will take a `function` as input. That function will be invoked in a new local scope.
reyoung
force-pushed
the
feature/scope_default_wrapper
branch
from
d41b811 to
d027f47
Compare
Superjomn
reviewed
Jul 11, 2017
| return __tl_scope__.cur_scope[-1] | ||
|
|
||
|
|
||
| def enter_local_scope(): |
Contributor
There was a problem hiding this comment.
scope 必须是连续么？
scopeA:
xxx
scope B:
xxxx
scopeA:
xxxx
不行么？
Collaborator
Author
There was a problem hiding this comment.
不是特别清楚什么是『必须连续』？
但是，举的例子可以做到。
enter_local_scope() # scope A
xxx
enter_local_scope() # scope B
xxx
leave_local_scope()
xxx
leave_local_scope() # leave scope A
jacquesqiao
reviewed
Jul 13, 2017
| return get_cur_scope().get_var(name) | ||
|
|
||
|
|
||
| def scoped_function(func): |
Member
There was a problem hiding this comment.
what is the situation to use this function?
Collaborator
Author
There was a problem hiding this comment.
Maybe used to define an RNN step net?
Member
There was a problem hiding this comment.
But the scope of stepnet is create inside RnnOP as far as know
jacquesqiao
approved these changes
Jul 13, 2017
Member
jacquesqiao
left a comment
jacquesqiao
left a comment
There was a problem hiding this comment.
LGTM with a small question
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paddlemanages Scope as programming language's scope. It just athread-local stack of Scope. Top of that stack is current scope, the
bottom of that stack is all scopes' parent.
Invoking
create_var/get_varcancreate/getvariable in currentscope. Invoking
enter_local_scope/leave_local_scopecan create ordestroy local scope.
A
scoped_functionwill take afunctionas input. That function willbe invoked in a new local scope.