add tensor interfaces #2809
Merged
add tensor interfaces #2809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add member variable 'DDim dims_' and a getter function 'dims()'. 'dims' is supposed to hold tensor's shape during Op::InferShape. 2. Remove 'mutable_data' which use default Place. User must specify a explicit Place when call 'mutable_data'. 3. A PlaceHolder may be shared by more than one tensor, and some of them may be the others' slices. So we add a new member variable 'offset_' for Tensor, which is used to show the byte offset between PlaceHolder::ptr_ and where tensor's data really begins. 4. Add functions 'ShareDataFrom' and 'Slice' for Tensor. TODO: Tensor needs a 'CopyFrom' function.
JiayiFeng
requested review from
QiJune,
Superjomn,
jacquesqiao,
luotao1,
qingqing01,
reyoung and
wangkuiyi
reyoung
approved these changes
Jul 12, 2017
Collaborator
reyoung
left a comment
reyoung
left a comment
There was a problem hiding this comment.
LGTM, except tiny little CPP syntax.
paddle/framework/tensor.h
Outdated
| public: | ||
| Tensor() : offset_(0) {} | ||
|
|
||
| Tensor(const DDim& dims) : dims_(dims), offset_(0) {} |
Collaborator
There was a problem hiding this comment.
explicit Tensor(const DDim& dims).
paddle/framework/tensor.h
Outdated
| offset_ = src.offset_; | ||
| } | ||
|
|
||
| Tensor Slice(const int& begin_idx, const int& end_idx) { |
Collaborator
There was a problem hiding this comment.
This function could be const
Tensor Slice(int begin_idx, int end_idx) const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DDim dims_and a getter functiondims().dims_is supposed to hold tensor's shape and it is required byOp::InferShape.mutable_datawhich use defaultPlace. Now users must provide an explicitPlaceas parameter when callingmutable_data. See Proposal: remove get_place and set_place #2742.PlaceHolder::ptr_and where tensor's data really begins.ShareDataFromandSlicefor Tensor.TODO: Tensor needs a 'CopyFrom' function
And there is another question. After
Op::InferShape, we are going to get a series of tensors which have only dims_ but no data(holder_ == nullptr). So it seems reasonable to add a new interface for these tensors' memory allocation:If not, we have to write: