Add build_android task on Travis CI. #2845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xreki
force-pushed
the
travis_build_android
branch
2 times, most recently
from
a619cb0 to
976d92c
Compare
Xreki
force-pushed
the
travis_build_android
branch
4 times, most recently
from
6a4a1e2 to
4f770d0
Compare
Xreki
force-pushed
the
travis_build_android
branch
from
4f770d0 to
62908dc
Compare
gangliao
reviewed
Jul 14, 2017
| # Compile paddle binaries | ||
| cmake -DCMAKE_SYSTEM_NAME=Android \ | ||
| -DANDROID_STANDALONE_TOOLCHAIN=$ANDROID_STANDALONE_TOOLCHAIN \ | ||
| -DANDROID_ABI=armeabi-v7a \ |
Contributor
Author
There was a problem hiding this comment.
arm64-v8a的编译，@hedaoyuan 已经在#2816 中支持了，若觉得有必要，可以直接在这个脚本里加上
Contributor
Author
There was a problem hiding this comment.
经过和@gangliao 讨论，在Travis CI中增加build_android编译任务的主要目的，是为了防止后续cmake的更新，导致android版编译失败，因而不需要再增加arm64-v8a的编译测试。
gangliao
reviewed
Jul 14, 2017
| cmake -DCMAKE_SYSTEM_NAME=Android \ | ||
| -DANDROID_STANDALONE_TOOLCHAIN=$ANDROID_STANDALONE_TOOLCHAIN \ | ||
| -DANDROID_ABI=armeabi-v7a \ | ||
| -DANDROID_ARM_NEON=ON \ |
Contributor
There was a problem hiding this comment.
-DWITH_TESTING=OFF disable build the test binaries
Contributor
Author
There was a problem hiding this comment.
线下编译的时候，一般都设置-DWITH_TESTING=ON，生成的二进制拷贝到Android设备上运行。设置-DWITH_TESTING=ON可以检查是否会有链接错误。
gangliao
approved these changes
Jul 14, 2017
Contributor
gangliao
left a comment
gangliao
left a comment
There was a problem hiding this comment.
almost LGTM, pls follow the comments.
Contributor
Author
|
【说明】由于Paddle的重构工作，可能会引入一些临时的修改：
为了防止 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.