Skip to content

add configuration helper for the gated unit. #2865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lcy-seso merged 2 commits into from
Jul 14, 2017
Merged

add configuration helper for the gated unit. #2865

lcy-seso merged 2 commits into from
Jul 14, 2017

Conversation

@lcy-seso
Copy link
Contributor

@lcy-seso lcy-seso commented Jul 14, 2017

add configuration helper for the gated unit.

@lcy-seso lcy-seso requested a review from luotao1 July 14, 2017 07:32
@lcy-seso lcy-seso force-pushed the add_gated_unit_layer branch from 3e128c3 to 087f7eb Compare July 14, 2017 07:39
luotao1
luotao1 reviewed Jul 14, 2017
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 小修下。

python/paddle/trainer_config_helpers/layers.py Outdated
Copy link
Contributor

@luotao1 luotao1 Jul 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个名字应该是gated_unit_layer吧

Copy link
Contributor Author

@lcy-seso lcy-seso Jul 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

python/paddle/trainer_config_helpers/layers.py Outdated
Copy link
Contributor

@luotao1 luotao1 Jul 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的x, x', sigma也写成公式表示吧。

Copy link
Contributor Author

@lcy-seso lcy-seso Jul 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

python/paddle/trainer_config_helpers/layers.py Outdated
Copy link
Contributor

@luotao1 luotao1 Jul 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5624行缺句号。下面的也检查下~

Copy link
Contributor Author

@lcy-seso lcy-seso Jul 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@lcy-seso lcy-seso force-pushed the add_gated_unit_layer branch from 087f7eb to 2acec48 Compare July 14, 2017 07:50
@lcy-seso lcy-seso force-pushed the add_gated_unit_layer branch from 2acec48 to ac69f77 Compare July 14, 2017 07:52
luotao1
luotao1 approved these changes Jul 14, 2017
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcy-seso lcy-seso merged commit 581cf90 into PaddlePaddle:develop Jul 14, 2017
@lcy-seso lcy-seso deleted the add_gated_unit_layer branch July 20, 2017 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luotao1 luotao1 luotao1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lcy-seso @luotao1