Skip to content

Conversation

@helinwang
Copy link
Contributor

Go pre-commit hook does not modify code, so git diff --exit-code will have 0 exit code in that case.

@helinwang helinwang requested review from gongweibao and reyoung July 15, 2017 00:19
@wangkuiyi
Copy link
Collaborator

Travis CI complains that it cannot find golint.

CRLF end-lines remover...............................(no files to check)Skipped
yapf.....................................................................Passed
Check for added large files..............................................Passed
Check for merge conflicts................................................Passed
Check for broken symlinks................................................Passed
Detect Private Key...................................(no files to check)Skipped
Fix End of Files.........................................................Passed
clang-formater...........................................................Passed
go fmt...................................................................Passed
go lint..................................................................Failed
hookid: go-lint
/home/travis/.pre-commit/repony4WjS/run-go-lint.sh: line 9: golint: command not found

@helinwang
Copy link
Contributor Author

@wangkuiyi Thanks for pointing out! #2885 fixes it, I will rebase the fix after that gets merged.

Copy link
Contributor

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@helinwang helinwang merged commit a818afc into PaddlePaddle:develop Jul 18, 2017
@helinwang helinwang deleted the fix_pre_commit branch July 18, 2017 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants