Skip to content

support multiple template parameter in KernelType for REGISTER_OP_XPU… #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jacquesqiao merged 1 commit into from
Jul 18, 2017
Merged

support multiple template parameter in KernelType for REGISTER_OP_XPU… #2932

jacquesqiao merged 1 commit into from
Jul 18, 2017

Conversation

@jacquesqiao
Copy link
Member

@jacquesqiao jacquesqiao commented Jul 18, 2017 •
edited
Loading

for macro like:

#define REGISTER_OP_CPU_KERNEL(type, KenelType) \
...

if KenelType have more then one template parameter, like

REGISTER_OP_CPU_KERNEL(xx, XxClass<float, float>)

because there is a ,, it will cause error like

error: too many arguments provided to function-like macro invocation

@jacquesqiao jacquesqiao requested review from JiayiFeng and reyoung July 18, 2017 03:58
@jacquesqiao jacquesqiao merged commit 051676a into PaddlePaddle:develop Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reyoung reyoung reyoung approved these changes

@JiayiFeng JiayiFeng Awaiting requested review from JiayiFeng

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jacquesqiao @reyoung