Add sgd op #2950
Merged
Add sgd op #2950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyoung
reviewed
Jul 19, 2017
paddle/operators/sgd_op.cc
Outdated
| AddInput("param", "input parameter"); | ||
| AddInput("grad", "input gradient"); | ||
| AddOutput("param_out", "output parameter"); | ||
| AddAttr<float>("learning_rate", "learning rate of sgd").SetDefault(0.1); |
Collaborator
There was a problem hiding this comment.
Do not set a default learning rate, because it should not be set by framework and must be set by user.
paddle/operators/sgd_op.cc
Outdated
| const std::vector<framework::Tensor *> &outputs) const override { | ||
| PADDLE_ENFORCE(inputs.size() == 2, "Input size of SGDOp must be two"); | ||
| PADDLE_ENFORCE(outputs.size() == 1, "Output size of SGDOp must be one"); | ||
| PADDLE_ENFORCE( |
Collaborator
There was a problem hiding this comment.
As we discussed before, PADDLE_ENFORCE should not take complex logic
dzhwinter
reviewed
Jul 19, 2017
paddle/operators/sgd_op_test.cc
Outdated
| limitations under the License. */ | ||
|
|
||
| #include <gtest/gtest.h> | ||
| #define private public |
| self.grad = numpy.random.random((342, 345)).astype("float32") | ||
| self.learning_rate = 0.1 | ||
| self.param_out = self.param - self.learning_rate * self.grad | ||
|
|
Contributor
There was a problem hiding this comment.
seems it is does not finished check?
Collaborator
There was a problem hiding this comment.
By using current op unit test framework, the developer only needs to setUp this variable, the test method is injected by OpTestMeta.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.