Skip to content

Refine the unit test of convolution function. #3392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hedaoyuan merged 6 commits into from
Aug 11, 2017
Merged

Refine the unit test of convolution function. #3392

hedaoyuan merged 6 commits into from
Aug 11, 2017

Conversation

@hedaoyuan
Copy link
Contributor

@hedaoyuan hedaoyuan commented Aug 10, 2017

No description provided.

@hedaoyuan hedaoyuan requested a review from NHZlX August 10, 2017 09:11
@NHZlX
Copy link
Contributor

NHZlX commented Aug 10, 2017

More and more test files are added to paddle/function, for users, it looks very messy, should we consider to building a folder ?

@NHZlX
Copy link
Contributor

NHZlX commented Aug 10, 2017

The refinement of the test of convolution function looks great to me.

@hedaoyuan
Copy link
Contributor Author

hedaoyuan commented Aug 10, 2017

More and more test files are added to paddle/function, for users, it looks very messy, should we consider to building a folder ?

Put the test file and source file in one directory is a new convention. You can see in the platform, operators, framework the test file and source file are also placed in a directory.

wangkuiyi
wangkuiyi approved these changes Aug 11, 2017
View reviewed changes
Copy link
Collaborator

@wangkuiyi wangkuiyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

赞！删了这么多代码！

有一个 C-style cast，应该改成C++ style 的。

paddle/function/nnpack/NNPACKConvOp.cpp Outdated
CHECK_EQ(strideW(), 1);

// TODO(hedaoyuan): There has some bug when batchSize > 1 and groups_ > 1.
CHECK_EQ(groups_, (size_t)1);
Copy link
Collaborator

@wangkuiyi wangkuiyi Aug 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(size_t)1 ==> size_t(1) or static_cast<size_t>(1), according to Google C++ style https://google.github.io/styleguide/cppguide.html#Casting

Copy link
Contributor Author

@hedaoyuan hedaoyuan Aug 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out. Done.

@hedaoyuan hedaoyuan merged commit d87c0b1 into PaddlePaddle:develop Aug 11, 2017
heavengate pushed a commit to heavengate/Paddle that referenced this pull request Aug 16, 2021
[dev] fix bug of cpp deploy when benchmark=True (PaddlePaddle#3392)
87848d4 
* fix bug when benchmark=True

* split warmup and repeat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangkuiyi wangkuiyi wangkuiyi approved these changes

@NHZlX NHZlX NHZlX approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hedaoyuan @NHZlX @wangkuiyi