Enable Code Coverage for Paddle refactor code #3489
Conversation
go/pserver/optimizer.go
Outdated
|
|
||
| // #cgo CFLAGS: -I ../../ | ||
| // #cgo LDFLAGS: ${SRCDIR}/client/c/libpaddle_go_optimizer.a -lstdc++ -lm | ||
| // #cgo LDFLAGS: /Users/liaogang/baidu/Paddle/go/pserver/client/c/libpaddle_go_optimizer.a -lstdc++ -lm -g -O0 -fprofile-arcs -ftest-coverage |
There was a problem hiding this comment.
please ignore this modification, because go/pserver/.gitignore is added.
There was a problem hiding this comment.
Use git rm PATH_TO_FILE to remove it from git.
|
Changes Unknown when pulling 539c86b on gangliao:coveralls into ** on PaddlePaddle:develop**. |
|
Changes Unknown when pulling 8ceee0f on gangliao:coveralls into ** on PaddlePaddle:develop**. |
reyoung
left a comment
reyoung
left a comment
There was a problem hiding this comment.
LGTM, except optimizer.go should be removed from git.
| @@ -15,7 +15,7 @@ | |||
| package pserver | |||
|
|
|||
| // #cgo CFLAGS: -I ../../ | |||
| // #cgo LDFLAGS: ${SRCDIR}/client/c/libpaddle_go_optimizer.a -lstdc++ -lm | |||
There was a problem hiding this comment.
Renaming optimizer.go to optimizer.go.in will break building from Go without cmake. Do we really need this?
There was a problem hiding this comment.
Maybe we can find another way to suppress this later.
|
Since you haven't replied for a long time, we have closed this issue/pr. |
4 participants
fix #3298
https://coveralls.io/github/PaddlePaddle/Paddle