Add 3DPoolingLayer #3504

chengduoZH · 2017-08-15T10:55:42Z

fix #438
Add 3DPoolingLayer.

chengduoZH · 2017-08-15T11:06:58Z

Start from "Add Pool3DLayer"

qingqing01 · 2017-08-18T10:48:12Z

Please remove 3DConv/3D-DeConv in this PR at first.

qingqing01 · 2017-08-22T12:09:26Z

paddle/cuda/include/hl_cnn.h

+ * @param[in]   paddingW    padding width.
+ * @param[out]  tgtData     output data.
+ * @param[in]   tgtStride   stride between output data samples.
+ *


remove comments, since the following argument names are clear.

qingqing01 · 2017-08-22T12:10:26Z

paddle/gserver/layers/Pool3DLayer.cpp

+  }
+  if (imgSizeW_ == 0) {
+    //    imgSizeW_ = imgSize_;
+  }


If these codes are out of use, please remove them

qingqing01 · 2017-08-22T12:12:03Z

paddle/math/Matrix.cpp

+                                 size_t paddingD,
+                                 size_t paddingH,
+                                 size_t paddingW) {
+  CHECK(inputMat.useGpu_ == true) << "Matrix type are not equal";


CHECK(inputMat.useGpu_) << "Matrix type is not correct";

qingqing01 · 2017-08-22T12:12:48Z

paddle/math/Matrix.cpp

+                                  size_t paddingH,
+                                  size_t paddingW) {
+  CHECK(inputMat.useGpu_ == true && outGrad.useGpu_ == true &&
+        outV.useGpu_ == true)


CHECK(inputMat.useGpu_ && outGrad.useGpu_ && outV.useGpu_)

qingqing01 · 2017-08-22T12:16:12Z

paddle/math/Matrix.cpp

+                                 size_t paddingD,
+                                 size_t paddingH,
+                                 size_t paddingW) {
+  CHECK(inputMat.useGpu_ == true) << "Matrix type are not equal";


same as above.

qingqing01 · 2017-08-22T12:55:06Z

paddle/gserver/layers/Pool3DLayer.cpp

+                                 outputH_,
+                                 outputW_,
+                                 1,
+                                 1,


qingqing01 · 2017-08-22T12:55:45Z

paddle/math/Matrix.h

                       real scaleOutput,
                       size_t paddingH,
                       size_t paddingW);
+  //////////////////////


remove this line.

qingqing01 · 2017-08-22T12:57:15Z

paddle/math/Matrix.h

+                         real scaleOutput,
+                         size_t paddingD,
+                         size_t paddingH,
+                         size_t paddingW);


虽然无关紧要，但是这些参数的顺序稍乱，尤其把real scaleTargets, real scaleOutput莫名的插在中间~

qingqing01 · 2017-08-22T12:57:38Z

paddle/math/tests/test_matrixCompare.cpp

+
+  cpuImage->randomizeUniform();
+  gpuImage->copyFrom(*cpuImage);
+  // std::cout << "test maxPool3DForward...\n";


remove this line.

qingqing01 · 2017-08-22T12:58:11Z

paddle/math/tests/test_matrixCompare.cpp

+TEST(Matrix, Pool3D) {
+  for (auto depth : {9, 16, 64, 128}) {
+    for (auto height : {9, 11, 128, 256}) {
+      for (auto width : {9, 32, 128}) {


减少测试case~

chengduoZH requested review from hedaoyuan and qingqing01 August 15, 2017 11:01

chengduoZH force-pushed the Add_3DPooling branch 3 times, most recently from 6e70deb to c5d0439 Compare August 18, 2017 10:24

chengduoZH force-pushed the Add_3DPooling branch from c5d0439 to 52d9db3 Compare August 21, 2017 05:23

Add3DPooling

2377d71

chengduoZH force-pushed the Add_3DPooling branch from 52d9db3 to 2377d71 Compare August 21, 2017 16:34

qingqing01 reviewed Aug 22, 2017

View reviewed changes

chengduoZH added 3 commits August 24, 2017 15:17

fix above comments

790379f

Add maxPoolIdx

860bf19

Add config parser for pooling3D

b1c0bad

chengduoZH force-pushed the Add_3DPooling branch 7 times, most recently from c836000 to b1c0bad Compare August 30, 2017 05:20

fix conflict

43da767

chengduoZH force-pushed the Add_3DPooling branch from 54629c0 to 43da767 Compare August 30, 2017 06:37

qingqing01 previously approved these changes Aug 30, 2017

View reviewed changes

fix data_layer for 3D data

f557b0c

chengduoZH dismissed qingqing01’s stale review via f557b0c August 30, 2017 16:12

chengduoZH force-pushed the Add_3DPooling branch from 9c24224 to 07985c9 Compare August 31, 2017 06:14

fix layers_test.py

d747c5d

chengduoZH force-pushed the Add_3DPooling branch from 07985c9 to d747c5d Compare August 31, 2017 06:52

Fix conflict and Add test_pooling3D_layer.protostr

a357bd6

qingqing01 previously approved these changes Aug 31, 2017

View reviewed changes

fix conflict

6374831

chengduoZH dismissed qingqing01’s stale review via 6374831 August 31, 2017 12:47

qingqing01 approved these changes Aug 31, 2017

View reviewed changes

chengduoZH merged commit fcad0a3 into PaddlePaddle:develop Aug 31, 2017

Add 3DPoolingLayer #3504

Add 3DPoolingLayer #3504

Uh oh!

Conversation

chengduoZH commented Aug 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chengduoZH commented Aug 15, 2017

Uh oh!

qingqing01 commented Aug 18, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chengduoZH commented Aug 15, 2017 •

edited

Loading