Remove flag use_mkldnn_wgt #3548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luotao1
reviewed
Aug 17, 2017
Contributor
luotao1
left a comment
luotao1
left a comment
There was a problem hiding this comment.
LGTM. 我用v1_api_demo/quick_start测过，是可以的。
| // After run some iters, the mkldnn weight has been stored in dnnLayer | ||
| // and we can also get the mkldnn weight paramter header format | ||
| // Weight param should always be index 0 (and bias index 1). | ||
| // TODO(TJ): should also considerate mean and var format when batchnorm ready |
Contributor
There was a problem hiding this comment.
- iters-iterations
- 349行header format后面加标点，parameter拼错
- 350行：Note that weight parameter(打全) XXX
- considerate->consider ，前者是形容词
paddle/parameter/Parameter.h
Outdated
|
|
||
| typedef enum { | ||
| PARAM_FORMAT_ORIGINAL = 0, // the paddle original basic format | ||
| PARAM_FORMAT_MKLDNN_OI, // the mkldnn format oi |
Contributor
There was a problem hiding this comment.
oi是其中一种mkldnn的格式吧。这里能给个链接么，或者给个详细点的说明。
不然大家会认为mkldnn就一种格式，可以说明下有很多种格式，oi只是其中一种。
paddle/parameter/Parameter.h
Outdated
| }; | ||
|
|
||
| /** | ||
| * @brief Is the header supported |
Contributor
There was a problem hiding this comment.
259行注释不全，文件头支持什么？
另外结束时请加标点，下面几处brief的注释一样。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #3409