cinn_launch_op: skip checking input variables must be used #37119
Conversation
|
Thanks for your contribution! |
… soft_cinn_launch_input_var_check
| @@ -171,6 +171,7 @@ endif() | |||
| if (WITH_CINN) | |||
| op_library(cinn_launch_op SRCS cinn_launch_op.cc cinn_launch_op.cu.cc DEPS transform_desc cinn_compiler cinn ${OP_HEADER_DEPS}) | |||
| cc_test(cinn_launch_op_test SRCS cinn_launch_op_test.cc DEPS cinn_compiler cinn_launch_op elementwise_add_op) | |||
| set_tests_properties(cinn_launch_op_test PROPERTIES ENVIRONMENT OMP_NUM_THREADS=1) | |||
There was a problem hiding this comment.
This comment is FYI (for you information). Currently, this test failed in Paddle-CINN CI due to libcublas version. Thank you for not setting it as RUN_TYPE=CINN
| const LoDTensor* paddle_tensor, | ||
| const CinnTensor& cinn_tensor) { | ||
| void CinnLaunchContext::CheckTensorEquivalent(const std::string& paddle_name, | ||
| const LoDTensor* paddle_tensor, |
There was a problem hiding this comment.
Paddle usually make non-null parameter as const reference instead of const pointer. Could you change the const LoDTensor* paddle_tensor to const LoDTensor& paddle_tensor?
There was a problem hiding this comment.
Ok, it is a good suggestion, thank you
|
|
||
| // check dimension | ||
| auto cinn_dims = framework::make_ddim(cinn_tensor->shape().data()); | ||
| PADDLE_ENFORCE_EQ(paddle_tensor->dims(), cinn_dims, | ||
| platform::errors::InvalidArgument( | ||
| "The tensor dimension in variable(%s) " | ||
| "is not equivalent, paddle is [%s] " | ||
| "Tensors dimension in variable(%s) " |
There was a problem hiding this comment.
NIT (Not important): I saw you noticed the English grammar error, but the change is not correct ...
Tensors' dimensions or Dimensions of tensors. The word "Dimensions" is the noun here and the verb is "are"
| [this](const auto& var_name) { | ||
| PADDLE_ENFORCE_GT(name2argument_.count(var_name), 0, | ||
| platform::errors::InvalidArgument( | ||
| "Variable(%s) is missed for launch " |
There was a problem hiding this comment.
Not Important: for launching
| hold_buffers.emplace_back(std::move(buffer)); | ||
| for (const auto& var_name : input_variable_names) { | ||
| if (!launch_context->IsVariableUsed(var_name)) { | ||
| // some input variables doesn't need for cinn because they are |
There was a problem hiding this comment.
"some input variables don't"
| } | ||
|
|
||
| const std::map<std::string, cinn_pod_value_t>& | ||
| CinnLaunchContext::FinalizeArguments() const { |
There was a problem hiding this comment.
改成下面的函数名如何？
| CinnLaunchContext::FinalizeArguments() const { | |
| CinnLaunchContext::CheckValidArguments() const { |
There was a problem hiding this comment.
这个函数需要返回最终参数，感觉直接叫check不合适，所以先不改了
PR types
Function optimization
PR changes
OPs
Describe
Modify serveral implements on CinnLaunchOp：
Run cinn_launch_op_test result:
Run test_resnet50_with_cinn.py result:
command:
FLAGS_allow_cinn_ops="elementwise_add;elementwise_add_grad;relu;relu_grad;sum;" python test_resnet50_with_cinn.py