[HeterPs] fix allocation #37476
Merged
[HeterPs] fix allocation #37476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ This PR's description meets the template requirements! |
|
Thanks for your contribution! |
Zjq9409
pushed a commit
to Zjq9409/Paddle
that referenced
this pull request
Dec 10, 2021
* auc temp * cuballocator * code format * code format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
现在框架里很多op都有类似这种写法，申请临时显存，然后launch kernel出作用域，这里出作用域后临时显存会释放，这样kernel会访问到已释放的显存；在现有paddle场景下（不会多线程申请同一个卡上显存）不会出问题，psgpu场景是每个线程会访问其他卡上的显存，这样会出问题（两个线程写同一块显存），例如concat op
https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/fluid/operators/math/concat_and_split.cu#L330