Skip to content

make dim int to int64_t #3900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QiJune merged 3 commits into from
Sep 6, 2017
Merged

make dim int to int64_t #3900

QiJune merged 3 commits into from
Sep 6, 2017

Conversation

@QiJune
Copy link
Member

@QiJune QiJune commented Sep 6, 2017

Fix #3889

JiayiFeng
JiayiFeng previously approved these changes Sep 6, 2017
View reviewed changes
Copy link
Collaborator

@JiayiFeng JiayiFeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

JiayiFeng
JiayiFeng approved these changes Sep 6, 2017
View reviewed changes
Copy link
Collaborator

@JiayiFeng JiayiFeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@QiJune QiJune merged commit 511b6e2 into PaddlePaddle:develop Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JiayiFeng JiayiFeng JiayiFeng approved these changes

@reyoung reyoung Awaiting requested review from reyoung

@gangliao gangliao Awaiting requested review from gangliao

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@QiJune @JiayiFeng