Skip to content

add offset implementation to lod tensor design #3934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Superjomn merged 3 commits into from
Sep 6, 2017
Merged

add offset implementation to lod tensor design #3934

Superjomn merged 3 commits into from
Sep 6, 2017

Conversation

@Superjomn
Copy link
Contributor

@Superjomn Superjomn commented Sep 6, 2017 •
edited by wangkuiyi
Loading

Fixes #3837

@Superjomn Superjomn merged commit 2282624 into PaddlePaddle:develop Sep 6, 2017
@Superjomn Superjomn deleted the lodtensor_offset_imple branch September 6, 2017 22:16
luotao1
luotao1 reviewed Sep 7, 2017
View reviewed changes
paddle/framework/lod_tensor.md
0 9 10
0 3 5 9 10 12
||| || |||| | || |||
```
Copy link
Contributor

@luotao1 luotao1 Sep 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有一些英文语法错误，需要再refine一下。另外需要说一下，为什么选择整体的length或offset，然后offset比length好的原因吧。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luotao1 luotao1 luotao1 left review comments

@wangkuiyi wangkuiyi wangkuiyi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Superjomn @wangkuiyi @luotao1