Skip to content

fix the full_like with fill the value of inf #40232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 9, 2022

Conversation

wawltor
Copy link
Contributor

@wawltor wawltor commented Mar 7, 2022

PR types

Bug fixes

PR changes

OPs

Describe

fix the full_like with fill the value of inf

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 7, 2022

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@@ -54,12 +54,22 @@ void FullLikeKernel(const Context& dev_ctx,

auto common_type_value = static_cast<CommonType>(value);

PADDLE_ENFORCE_EQ(
(common_type_value >=
// Judge the fill value is valid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check whether the filled value is valid

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed it

Copy link
Contributor

@joey12300 joey12300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit ec58289 into PaddlePaddle:develop Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants