Skip to content

Fix bug in cc_library, when merging several libraries into one on Linux. #4320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Xreki merged 1 commit into from
Sep 22, 2017
Merged

Fix bug in cc_library, when merging several libraries into one on Linux. #4320

Xreki merged 1 commit into from
Sep 22, 2017

Conversation

@Xreki
Copy link
Contributor

@Xreki Xreki commented Sep 22, 2017 •
edited
Loading

Fix #4321

@Xreki Xreki requested a review from NHZlX September 22, 2017 08:37
NHZlX
NHZlX approved these changes Sep 22, 2017
View reviewed changes
Copy link
Contributor

@NHZlX NHZlX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already tested，LGTM

@Xreki Xreki merged commit 2d8467e into PaddlePaddle:develop Sep 22, 2017
@Xreki Xreki deleted the fix_android_linking_error branch November 14, 2018 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NHZlX NHZlX NHZlX approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Xreki @NHZlX