Skip to content

Conversation

@kuke
Copy link
Contributor

@kuke kuke commented Sep 25, 2017

Resolve #4359

@kuke kuke changed the title Replace LoDTensor in multiplex_op Modify multiplex_op Sep 25, 2017
@kuke kuke requested a review from qingqing01 September 25, 2017 13:18

for (size_t i = 2; i < num_ins; i++) {
auto in_dim = ins[0]->dims();
PADDLE_ENFORCE(in_dim.size() == 2, "Candidate tensors must be matrix.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Candidate tensors不是必需2维吧~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the limitation

qingqing01
qingqing01 previously approved these changes Sep 26, 2017
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuke kuke merged commit 367a54e into PaddlePaddle:develop Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants